fix(sqlparser): array of struct of struct #19483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxchan
reviewed
Nov 21, 2024
| @@ -74,3 +74,6 @@ | |||
| sql parser error: expected an expression, found: [ | |||
| LINE 1: SELECT [1,2] | |||
| ^ | |||
| - input: CREATE TABLE t (params STRUCT<a STRUCT<b int>>[]) | |||
There was a problem hiding this comment.
This test case seems to work in current version. Did I miss something?
dev=> CREATE TABLE t (params STRUCT<a STRUCT<b int>>[])
dev-> ;
CREATE_TABLE
dev=> describe t;
┌───────────────────┬─────────────────────┬───────────┬─────────────┐
│ Name │ Type │ Is Hidden │ Description │
├───────────────────┼─────────────────────┼───────────┼─────────────┤
│ params │ │ false │ ∅ │
│ params.a │ struct<b integer>[] │ false │ ∅ │
│ _row_id │ serial │ true │ ∅ │
│ primary key │ _row_id │ ∅ │ ∅ │
│ distribution key │ _row_id │ ∅ │ ∅ │
│ table description │ t │ ∅ │ ∅ │
└───────────────────┴─────────────────────┴───────────┴─────────────┘
(6 rows)
There was a problem hiding this comment.
Oh, it's wrong
dev=> show create table t;
┌──────────┬───────────────────────────────────────────────────┐
│ Name │ Create Sql │
├──────────┼───────────────────────────────────────────────────┤
│ public.t │ CREATE TABLE t (params STRUCT<a STRUCT<b INT>[]>) │
└──────────┴───────────────────────────────────────────────────┘
There was a problem hiding this comment.
How did you find the bug? Is it related with other bugs?
There was a problem hiding this comment.
See the linked issue. It was causing a schema mismatch panic when sink into table.
There was a problem hiding this comment.
Oh, I didn't notice there's linked issue since there's no fix #xx in body 😄
xxchan
approved these changes
Nov 21, 2024
Curious how did you generated this graph and what did you use it for? 👀 |
|
This was referenced Nov 22, 2024
BugenZhao
approved these changes
Nov 22, 2024
BugenZhao
approved these changes
Nov 22, 2024
BugenZhao
approved these changes
Nov 22, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
Co-authored-by: xiangjinwu <[email protected]> Co-authored-by: Xiangjin <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
Co-authored-by: xiangjinwu <[email protected]> Co-authored-by: Xiangjin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
When parsing
>>[], whose token stream contains[ShiftRight, LBracket, RBracket], the parser first consumesShiftRightand sets internal stateremaining_close = true. At this stage, it shall consider the next token as effectivelyGtrather than peeking atLBracketfrom the stream. In the latter case it would be wrongly parsed as>[]>dot
Limitations:
remaining_closefirst as if it was the next token. But I cannot find a good way to ensure such a virtual stream is followed (mutating input stream is not an option as it breaks backtrack and location reporting). The current fix only applies to array syntax[]as suffix. Hopefully no future syntax extensions hit the same problem.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.